Can not create seldondSeldonDeployment crd in k8s v1.19.2

[simon-cj]

Describe the bug

we install seldon operator in k8s v1.19.2, but it is error to create crd. the error as follow:

* spec.validation.openAPIV3Schema.properties[spec].properties[predictors].items.properties[explainer].properties[containerSpec].properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[spec].properties[predictors].items.properties[componentSpecs].items.properties[spec].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[spec].properties[predictors].items.properties[componentSpecs].items.properties[spec].properties[containers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[spec].properties[predictors].items.properties[graph].properties[children].items.type: Required value: must not be empty for specified array items

if we use https://github.com/SeldonIO/seldon-core/blob/master/operator/config/crd/bases/machinelearning.seldon.io_seldondeployments.yaml, there are ok.
but if we generate crd yaml by running make manifests_v1, it is not work.

Need you help @cliveseldon

To reproduce

Expected behaviour

Environment

Model Details

• Images of your model: [Output of: kubectl get seldondeployment -n <yourmodelnamespace> <seldondepname> -o yaml | grep image: where <yourmodelnamespace>]
• Logs of your model: [You can get the logs of your model by running kubectl logs -n <yourmodelnamespace> <seldonpodname> <container>]

[ukclivecox]

I tried with master on a 1.19.1 Kind cluster make install_v1 and this worked.

The errors mentioned should all be fixed in v1 manifests by

seldon-core/operator/config/crd_v1/kustomization.yaml

Lines 22 to 38 in 3c943be

	# Ensure multiple levels of graph defn in OpenAPISpec as you can't have references let alone recursive refs
	# https://github.com/kubernetes/kubernetes/issues/54579
	- target:
	group: apiextensions.k8s.io
	version: v1
	kind: CustomResourceDefinition
	name: seldondeployments.machinelearning.seldon.io
	path: patches/graph_children.yaml
	# kubebuilder/k8s has an issues that Protocol from core types is not fully specied w.r.t OpenAPISchema
	# https://github.com/kubernetes/kubernetes/issues/91395
	# This fixes that by adding a TCP default
	- target:
	group: apiextensions.k8s.io
	version: v1
	kind: CustomResourceDefinition
	name: seldondeployments.machinelearning.seldon.io
	path: patches/protocol.yaml

[simon-cj]

Thanks for your reply， it is ok, we found it that we can not use the crd which is generate by make manifests_v1, by kustomize command, it patch some default value, now it works.
Thanks again.

[ukclivecox]

Will close, please reopen if still an issue.