Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor env var retrieval for model_name / image_name in python wrapper so it's centralised in util #2621

Closed
RafalSkolasinski opened this issue Nov 10, 2020 — with Board Genius Sync · 0 comments · Fixed by #3417 or #3420
Closed

Refactor env var retrieval for model_name / image_name in python wrapper so it's centralised in util #2621

RafalSkolasinski opened this issue Nov 10, 2020 — with Board Genius Sync · 0 comments · Fixed by #3417 or #3420
Assignees
@sakoush
Milestone
1.6

Comments

@RafalSkolasinski Board Genius Sync
Copy link
Contributor

We should refactor helper code that retrieve model / image name from environmental variable in Seldon Core so all of it resides in utils.py.

https://github.com/SeldonIO/seldon-core/pull/2587/files/66003212b0d85cfeffbe3dc808c35c9a0ab29097#r519922175

https://github.com/SeldonIO/seldon-core/pull/2587/files/66003212b0d85cfeffbe3dc808c35c9a0ab29097#r519922806
@RafalSkolasinski RafalSkolasinski added the triage Needs to be triaged and prioritised accordingly label Nov 10, 2020
@RafalSkolasinski RafalSkolasinski mentioned this issue Nov 10, 2020
Merged
@axsaucedo axsaucedo changed the title refactor model_name / image_name retrival code in python wrapper Refactor env var retrieval for model_name / image_name in python wrapper so it's centralised in util Nov 12, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Nov 19, 2020
@ukclivecox ukclivecox added this to the 1.6 milestone Nov 19, 2020
@axsaucedo axsaucedo changed the title Refactor env var retrieval for model_name / image_name in python wrapper so it's centralised in util OSS-147: Refactor env var retrieval for model_name / image_name in python wrapper so it's centralised in util Apr 26, 2021
@axsaucedo axsaucedo changed the title OSS-147: Refactor env var retrieval for model_name / image_name in python wrapper so it's centralised in util Refactor env var retrieval for model_name / image_name in python wrapper so it's centralised in util Apr 28, 2021
@sakoush sakoush mentioned this issue Jul 21, 2021
Merged
@sakoush sakoush mentioned this issue Jul 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakoush sakoush

Labels
None yet
Projects
None yet
Milestone
1.6
4 participants
@axsaucedo @sakoush @ukclivecox @RafalSkolasinski