Support YAML for SeldonDeployment definition in examples under seldon-core/helm-charts

[ramanNarasimhan77]

Hello,

I am trying to customise and reuse the model deployment helm charts available under seldon-core/helm-charts for deploying the ml models that my team is building.
Our generic ci process lints every helm chart before uploading to our internal registry. Helm linting does not work with json.
Is there a way I can easily redefine helm charts like seldon-single-model to use yaml instead of json

Steps in CI process for uploading a helm chart to Helm registry:

1. Update Chart version in Chart.yaml
2. Update dependencies helm dep up $CHART
3. Lint helm chart helm lint $CHART
4. Package the helm chart helm package -d . $CHART
5. Push packaged chart to internal helm registry

Error observed on running lint command:

Linting error:
$ helm lint seldon-single-model
==> Linting seldon-single-model
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/seldondeployment.json: file extension '.json' not valid. Valid extensions are .yaml, .yml, .tpl, or .txt

[ellisvalentiner]

@ramanNarasimhan77 you can just change the extension to .yaml and it will work fine because JSON is valid YAML.

[ramanNarasimhan77]

@ellisvalentiner thank you for the suggestion. I will try this out

[ukclivecox]

You could raise a PR to change to yaml or push Helm to accept JSON for lint