Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TerminationGracePeriodSeconds not respected in CRD #2332

Closed
ukclivecox opened this issue Aug 27, 2020 · 0 comments · Fixed by #2345
Closed

TerminationGracePeriodSeconds not respected in CRD #2332

ukclivecox opened this issue Aug 27, 2020 · 0 comments · Fixed by #2345
Assignees
Milestone

Comments

@ukclivecox
Copy link
Contributor

Describe the bug

TerminationGracePeriodSeconds not respected in CRD

To reproduce

deploy

apiVersion: machinelearning.seldon.io/v1
kind: SeldonDeployment
metadata:
  name: seldon-model
spec:
  name: test-deployment
  predictors:
  - componentSpecs:
    - spec:
        containers:
        - image: seldonio/mock_classifier_rest:1.3
          name: classifier
        terminationGracePeriodSeconds: 1
    graph:
      children: []
      endpoint:
        type: REST
      name: classifier
      type: MODEL
    name: example
    replicas: 1

Pod will have terminationGracePeriodSeconds: 20

Expected behaviour

Environment

Model Details

  • Images of your model: [Output of: kubectl get seldondeployment -n <yourmodelnamespace> <seldondepname> -o yaml | grep image: where <yourmodelnamespace>]
  • Logs of your model: [You can get the logs of your model by running kubectl logs -n <yourmodelnamespace> <seldonpodname> <container>]

There are two parts of the code that have this hardwired:
https://github.com/SeldonIO/seldon-core/search?l=Go&q=TerminationGracePeriodSeconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant