Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest-runner dependency from setup.py #2303

Closed
ai-athena-oracle opened this issue Aug 20, 2020 · 1 comment
Closed

Remove pytest-runner dependency from setup.py #2303

ai-athena-oracle opened this issue Aug 20, 2020 · 1 comment
Labels
triage Needs to be triaged and prioritised accordingly

Comments

@ai-athena-oracle
Copy link

ai-athena-oracle commented Aug 20, 2020

In Python library of Seldon, there is a line in setup.py which says setup_requires=["pytest-runner"]. This is only needed if one wants to run tests this way python setup.py pytest but it bring another main dependency to the package. You already have pytest dependency in tests_require , which is a cleaner practice to add test dependencies. This allow
to run tests this way pytest tests, which has the same effect as the other approach. Bringing an extra dependency (especially, which is only used for tests) to the main package introduces an additional issue for big companies, which require taking each dependency through rigorous approval process.

Another argument for removing pytest-runner is that this package has a deprecation notice:

pytest-runner depends on deprecated features of setuptools and relies on features that break security mechanisms in pip. For example 'setup_requires' and 'tests_require' bypass pip --require-hashes. See also https://github.com/pypa/setuptools/issues/1684.
@ai-athena-oracle ai-athena-oracle added the triage Needs to be triaged and prioritised accordingly label Aug 20, 2020
@ai-athena-oracle
Copy link
Author

Duplicate to #2302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

No branches or pull requests

1 participant