Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Payload Logger to use V1 Cloudevents #1958

Closed
ukclivecox opened this issue Jun 16, 2020 · 2 comments · Fixed by #1959
Closed

Update Payload Logger to use V1 Cloudevents #1958

ukclivecox opened this issue Jun 16, 2020 · 2 comments · Fixed by #1959
Assignees
@ukclivecox
Milestone
1.2

Comments

@ukclivecox
Copy link
Contributor

  • Update cloudevents go library
  • Update code to use V1 protocol
@ukclivecox ukclivecox added this to the 1.2 milestone Jun 16, 2020
@ukclivecox ukclivecox self-assigned this Jun 16, 2020
@ryandawsonuk
Copy link
Contributor

Oh I thought we were already #1857. Maybe I looked in the wrong place. Presumably I should have looked at https://github.com/SeldonIO/seldon-core/blob/master/executor/go.mod#L6

@ukclivecox
Copy link
Contributor Author

Looks like we are using V1 but the library is old. So only need to update library.

@ukclivecox ukclivecox mentioned this issue Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukclivecox ukclivecox

Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Update cloudevents library to 1.2.0
2 participants
@ukclivecox @ryandawsonuk