seldon-single-model chart doesn't install

[ryandawsonuk]

Error: YAML parse error on seldon-single-model/templates/seldondeployment.json: error converting YAML to JSON: yaml: line 6: did not find expected ',' or '}'
helm.go:75: [debug] error converting YAML to JSON: yaml: line 6: did not find expected ',' or '}'

I'm sure I used this about a month ago. The most recent change is 22777a2. And error is line 6 so presumably that change has led to the json being invalid somehow.

[ryandawsonuk]

No it's the other way around. That commit is the fix and I just haven't merged it into my branch.

[ryandawsonuk]

Rebased and still fails in the operator when I do an install:

2020-06-15T08:32:30.442Z        ERROR   controller-runtime.controller   Reconciler error        {"controller": "seldon-controller-manager", "request": "default/seldon-single-model", "error": "Deployment.apps \"seldon-single-model-default-0-model\" is invalid: spec.template.spec.containers[0].image: Required value"}
github.com/go-logr/zapr.(*zapLogger).Error
        /go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:258

Looking at the SeldonDeployment manifest, the container spec is indeed missing any image.

[ryandawsonuk]

OK I see that the example has been updated - https://github.com/SeldonIO/seldon-core/blob/master/examples/centralised-logging/full-kind-setup.sh#L58 I was just running the old version.