Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove probesonly flag #1856

Closed
glindsell opened this issue May 20, 2020 · 0 comments
Closed

Remove probesonly flag #1856

glindsell opened this issue May 20, 2020 · 0 comments
Assignees
@glindsell

Comments

@glindsell
Copy link
Contributor

probesOnly is no longer needed. e.g.:

if !probesOnly {
		serverMetrics = metric.NewServerMetrics(predictor, deploymentName)
	}

See comment from @cliveseldon : #1772 (comment)
@glindsell glindsell added the triage Needs to be triaged and prioritised accordingly label May 20, 2020
@glindsell glindsell mentioned this issue May 20, 2020
Merged
@glindsell glindsell self-assigned this May 20, 2020
@glindsell glindsell added this to the 1.2 milestone May 20, 2020
@glindsell glindsell removed the triage Needs to be triaged and prioritised accordingly label May 20, 2020
@ukclivecox ukclivecox removed this from the 1.2 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glindsell glindsell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ukclivecox @glindsell