Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to access /health/status and /metadata endpoints defined in seldon through ambassador #1822

Closed
divyadilip91 opened this issue May 13, 2020 — with Board Genius Sync · 13 comments
Labels

Comments

Copy link

divyadilip91 commented May 13, 2020

Hi,

At present, I have noticed that /health/status and /metadata endpoints are accessible when the docker is run locally and tested
Eg: curl http://ipaddress/health/status
But when I try to access http://ambassadorexposedip/prefix/health/status, it shows 404 error.
So is /api/v0.1/predictions endpoint only accessible through ambassador?
Please do Reply

@divyadilip91 divyadilip91 added the triage Needs to be triaged and prioritised accordingly label May 13, 2020
@ukclivecox
Copy link
Contributor

Yes - we need to extend the external API to add status, health and metadata endpoints that are applicable per model component and for the entire graph. @RafalSkolasinski

@ukclivecox ukclivecox added priority/p1 and removed triage Needs to be triaged and prioritised accordingly labels May 13, 2020
@divyadilip91
Copy link
Author

Thankyou @cliveseldon .So would this be applicable for the other endpoints as well such as /predict , /transform-input ,/transform-output , /route , /aggregate ?

@ukclivecox
Copy link
Contributor

Was not thinking those as they are internal to the inference graph. But the ability to call any sub-part of the inference graph externally would be useful for testing.

@divyadilip91
Copy link
Author

Yes true

@RafalSkolasinski
Copy link
Contributor

I do believe that single model metadata endpoints are already available, for example

curl -s http://ambassador.mydomain.com/seldon/seldon/my-deployment/api/v1.0/metadata/my-model

@divyadilip91
Copy link
Author

I do believe that single model metadata endpoints are already available, for example

curl -s http://ambassador.mydomain.com/seldon/seldon/my-deployment/api/v1.0/metadata/my-model

my-model is the name of the model used in the graph rite?
Is this available in seldon v1.1.0?

@RafalSkolasinski
Copy link
Contributor

Yes, that's the name used in the graph. It should be available in v1.1.0 if you run the new golang orchestrator (default).

@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented May 13, 2020

The single model metadata (via ambassador) are covered in the example: https://docs.seldon.io/projects/seldon-core/en/latest/examples/metadata.html

@divyadilip91
Copy link
Author

@RafalSkolasinski Ok..so will this work if we have multinode graph?
Eg : a graph with a transformer and model.

@RafalSkolasinski
Copy link
Contributor

This right now is querying the a single model at a time specified by the endpoint you're calling.
But yes, it will work with multi-node graphs but you have now to call each endpoint on your own.

We are currently working on providing a graph-level metadata in #1728 (including all models' metadata too) but this is still WIP with initial PR #1803 to land soon.

I guess the scope of the issue here would be to allow for sth like

curl -s http://ambassador.mydomain.com/seldon/seldon/my-deployment/api/v1.0/health/my-model

to work in similar manner as metadata.

@divyadilip91
Copy link
Author

@RafalSkolasinski Yes

@divyadilip91
Copy link
Author

Was not thinking those as they are internal to the inference graph. But the ability to call any sub-part of the inference graph externally would be useful for testing.

@RafalSkolasinski Is this possible to be included in future seldon version wherein we can call the subpart of inference graph using the ambassador endpoint?

@axsaucedo axsaucedo changed the title Is it possible to access /health/status and /metadata endpoints defined in seldon through ambassador OSS-70: Is it possible to access /health/status and /metadata endpoints defined in seldon through ambassador Apr 26, 2021
@axsaucedo axsaucedo changed the title OSS-70: Is it possible to access /health/status and /metadata endpoints defined in seldon through ambassador Is it possible to access /health/status and /metadata endpoints defined in seldon through ambassador Apr 28, 2021
@ukclivecox ukclivecox added v2 and removed priority/p2 labels Jan 9, 2022
@ukclivecox
Copy link
Contributor

In v2 you can check status of individual models as well as for Pipelines get overall readiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants