Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support runtime request tags / metrics in thread/process safe way #1735

Closed
RafalSkolasinski opened this issue Apr 23, 2020 · 2 comments · Fixed by #2442
Closed

support runtime request tags / metrics in thread/process safe way #1735

RafalSkolasinski opened this issue Apr 23, 2020 · 2 comments · Fixed by #2442
Assignees
@RafalSkolasinski
Labels
Metrics priority/p1
Milestone
1.3

Comments

@RafalSkolasinski
Copy link
Contributor

Follow up from #1480.
As tags work now now as request metadata we should provide to users a tested and documented way on how to set them in thread/process safe manner from, in example, the predict method.
@RafalSkolasinski RafalSkolasinski added the triage Needs to be triaged and prioritised accordingly label Apr 23, 2020
@ukclivecox ukclivecox added priority/p2 and removed triage Needs to be triaged and prioritised accordingly labels Apr 30, 2020
@RafalSkolasinski
Copy link
Contributor Author

This should also encompass metrics - related to #2240

@RafalSkolasinski RafalSkolasinski changed the title provide means to set runtime request tags in thread/process safe manner provide means to set runtime request tags / metrics in thread/process safe manner Aug 4, 2020
@RafalSkolasinski RafalSkolasinski changed the title provide means to set runtime request tags / metrics in thread/process safe manner support runtime request tags / metrics in thread/process safe way Aug 4, 2020
@RafalSkolasinski RafalSkolasinski mentioned this issue Aug 4, 2020
Closed
@RafalSkolasinski
Copy link
Contributor Author

/priority p1

@RafalSkolasinski RafalSkolasinski added this to the 1.3 milestone Aug 4, 2020
@axsaucedo axsaucedo mentioned this issue Sep 8, 2020
Closed
@RafalSkolasinski RafalSkolasinski mentioned this issue Sep 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafalSkolasinski RafalSkolasinski

Labels
Metrics priority/p1
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

add support for runtime metrics
4 participants
@axsaucedo @ukclivecox @RafalSkolasinski @seldondev