Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seldon.io/rest-read-timeout for ambassador doesn't take effect in executor 1.1.0? #1724

Closed
JulianBarr opened this issue Apr 22, 2020 · 2 comments · Fixed by #1843
Closed
Assignees
Milestone

Comments

@JulianBarr
Copy link

While testing executor 1.1.0, I noticed that ambassador always take time out after about 3 seconds which should be the default setting.

I searched and noticed that java engines actually take seldon.io/rest-read-timeout to ambassador mapping timeout_ms. Is this not implemented in go version executor? If so, is there any way to work around with this?

Thanks.

@JulianBarr JulianBarr added bug triage Needs to be triaged and prioritised accordingly labels Apr 22, 2020
@JulianBarr
Copy link
Author

I figured out that ambassador custom config does work.

@ukclivecox
Copy link
Contributor

This could be a docs bug can you try the annotation on https://docs.seldon.io/projects/seldon-core/en/v1.1.0/graph/annotations.html

@ukclivecox ukclivecox added priority/p1 and removed triage Needs to be triaged and prioritised accordingly labels Apr 23, 2020
@ukclivecox ukclivecox added this to the 1.2 milestone Apr 23, 2020
@ukclivecox ukclivecox self-assigned this Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants