Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explainer not garbage collected if spec updated #1427

Closed
ukclivecox opened this issue Feb 12, 2020 · 2 comments
Closed

Explainer not garbage collected if spec updated #1427

ukclivecox opened this issue Feb 12, 2020 · 2 comments
Assignees
@ukclivecox
Labels
bug
Milestone
1.1

Comments

@ukclivecox
Copy link
Contributor

If an explainer is removed from spec any existing explainer deployment should be deleted.
@ukclivecox ukclivecox added the bug label Feb 12, 2020
@ukclivecox ukclivecox added this to the 1.1 milestone Feb 12, 2020
@ukclivecox ukclivecox self-assigned this Feb 12, 2020
@ukclivecox
Copy link
Contributor Author

This works fine with a well defined explainer. Removing it from the spec removes the deployment and associated service.

@ukclivecox
Copy link
Contributor Author

It also works when the explainer has an error. If you remove the explainer part and reapply the explainer is deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukclivecox ukclivecox

Labels
bug
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@ukclivecox