new v1.0.0 CRD's resources validator is not backward compatible

[yufengshan]

After upgraded to seldon v1.0.0 (with latest CRD) from v0.51/v0.4. The operator report error as below. It seems the new CRD has stricter validation requirement in the sdep resources section. With the following changes, operator can successfully deploy the sdep.

         limits:
-          cpu: 4
+          cpu: "4"
           memory: 4Gi
         requests:
-          cpu: 1
+          cpu: "1"

This breaks the backward compatibility, engineers have to update their sdeps. Can someone take a look to make it backward compatible? Thanks.

============ error ==============

.predictors.componentSpecs.spec.containers.resources.limits.cpu in body must be of type string: \"integer\"\nspec.predictors.componentSpecs.spec.containers.resources.requests.cpu in body must be of t
ype string: \"integer\""}                                                                                                                                                                              
github.com/go-logr/zapr.(*zapLogger).Error                                                                                                                                                             
        /go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128                                                                                                                                         
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler                                                                                                                  
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:218                                                                                                    
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem                                                                                                               
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:192                                                                                                    
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker                                                                                                                            
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:171                                                                                                    
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1                                                                                                                                                    
        /go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:152                                                                                                   
k8s.io/apimachinery/pkg/util/wait.JitterUntil                                                                                                                                                          
        /go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:153                                                                                                   
k8s.io/apimachinery/pkg/util/wait.Until                                                                                                                                                                
        /go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:88 ```

[ukclivecox]

The OpenAPISchema spec is generated automatically by Kubebuilder which generates the CRD yaml from the golang spec. The actual value is meant to be a string : see https://kubernetes.io/docs/tasks/configure-pod-container/assign-cpu-resource/

However, I agree kubectl allows one to use integers.

[ukclivecox]

The value is a Quantity which is meant to be a string: see https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.15/#quantity-resource-core
When a Quantity is parsed from a string...

However, kubectl does allow integer for values of this and seems to parse them to Quantities.

[ukclivecox]

I agree this is a braking change but I think it may be hard to implement the kubectl functionality which is above and beyond what CRDs provide without some hacks to the OpenAPISchema which is as stated generated.

We could update the docs FAQs for this?

[ukclivecox]

This works with the current master code on 1.16. Please reopen if still an issue.
Tested with:

apiVersion: machinelearning.seldon.io/v1
kind: SeldonDeployment
metadata:
  name: seldon-model
spec:
  name: test-deployment
  predictors:
  - componentSpecs:
    - spec:
        containers:
        - image: seldonio/mock_classifier_rest:1.3
          name: classifier
          resources:
            requests:
              memory: 1Gi
              cpu: 1
            limits:
              memory: 1Gi
              cpu: 2
    graph:
      children: []
      endpoint:
        type: REST
      name: classifier
      type: MODEL
    name: example
    replicas: 1