You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Shallow copies are currently used to set and handle config, for example:
cfg=self.config.copy()
This is OK if all any dictionary items are replaced, but might lead to unexpected behaviour if any items are mutated. We should audit all instances and replace with deepcopy where necessary.
Tracker for three items identified in #681.
Item 1 (#681 (comment))
Shallow copies are currently used to set and handle config, for example:
This is OK if all any dictionary items are replaced, but might lead to unexpected behaviour if any items are mutated. We should audit all instances and replace with
deepcopy
where necessary.Item 2 (#681 (comment))
We should replace
kernel_a: Union[nn.Module, str] = 'rbf'
's withLiteral
's in the kernel submodules, sincerbf
is the only permitted string value.Item 3 (#681 (comment))
Possibly refactor
if
statements, e.g.:The text was updated successfully, but these errors were encountered: