$mustRotate in RotatingFileHandler not resetting properly

[khoanguyen-3fc]

Our team is using Monolog version 2 and has encountered an issue where the $mustRotate attribute of the RotatingFileHandler is only set to false if all unrelated conditions in the rotate method are satisfied:

monolog/src/Monolog/Handler/RotatingFileHandler.php

Lines 128 to 171 in 884aa47

	/**
	* Rotates the files.
	*/
	protected function rotate(): void
	{
	// update filename
	$this->url = $this->getTimedFilename();
	$this->nextRotation = new \DateTimeImmutable('tomorrow');
	// skip GC of old logs if files are unlimited
	if (0 === $this->maxFiles) {
	return;
	}
	$logFiles = glob($this->getGlobPattern());
	if (false === $logFiles) {
	// failed to glob
	return;
	}
	if ($this->maxFiles >= count($logFiles)) {
	// no files to remove
	return;
	}
	// Sorting the files by name to remove the older ones
	usort($logFiles, function ($a, $b) {
	return strcmp($b, $a);
	});
	foreach (array_slice($logFiles, $this->maxFiles) as $file) {
	if (is_writable($file)) {
	// suppress errors here as unlink() might fail if two processes
	// are cleaning up/rotating at the same time
	set_error_handler(function (int $errno, string $errstr, string $errfile, int $errline): bool {
	return false;
	});
	unlink($file);
	restore_error_handler();
	}
	}
	$this->mustRotate = false;
	}

This issue interacts with Octane, leading to a serious problem where logs cannot rotate to a new file. The problem arises because the reset method is called on every RequestReceived:

https://github.com/laravel/octane/blob/2.x/src/Listeners/FlushMonologState.php

When a RotatingFileHandler instance is reset with true === $this->mustRotate, the $this->url and $this->nextRotation attributes are updated by calling rotate:

monolog/src/Monolog/Handler/RotatingFileHandler.php

Lines 133 to 135 in 884aa47

	// update filename
	$this->url = $this->getTimedFilename();
	$this->nextRotation = new \DateTimeImmutable('tomorrow');

As a result, the write method cannot write to the new stream because $this->close() is never reached. This occurs because $this->nextRotation is already updated during the call to reset:

monolog/src/Monolog/Handler/RotatingFileHandler.php

Lines 113 to 126 in 884aa47

	protected function write(array $record): void
	{
	// on the first record written, if the log is new, we should rotate (once per day)
	if (null === $this->mustRotate) {
	$this->mustRotate = null === $this->url || !file_exists($this->url);
	}
	if ($this->nextRotation <= $record['datetime']) {
	$this->mustRotate = true;
	$this->close();
	}
	parent::write($record);
	}