-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a python package of flexmeasures-entsoe #33
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: Nicolas Höning <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I tested installing locally and importing just via the name flexmeasures_entsoe
.
I added two small improvements in the Readme myself.
For the detailled&pinned requirements (.txt), I wonder if they are needed. This is always going to be installed in addition to FlexMeasures, so I'd always use the .in versions. I'd otherwise easily run into clashed between the installed dependencies for FlexMeasures and the ones for the plugin. What do you think?
Signed-off-by: Nicolas Höning <[email protected]>
Should I merge this PR? |
We still need to decide on getting rid of the pinned dependencies (.txt). See my comment above. |
Are there any plans to merge this in at some point? |
Yes that would be great. Was there anything blocking this, @Ahmad-Wahid ? |
…-make-a-real-package
To get rid of the pinned requirements, should I just remove the files or the requirements? |
The open question was if pinned dependencies should stay. Here are my thoughts:
|
I was also wondering about this with our smart-buildings plugin recently, where it isn't (yet) listed as a dependency, but I thought about including it. I haven't got a final answer, but just wanted to make an argument for including (keeping) the dependency: as a dev, if flexmeasures is installed in my local environment, it helps my IDE find imported functions and read their docstrings. So maybe include it as a dev dependency only? |
Yes, we can try that. |
In this PR, I have tried to create a pip installable package of our entsoe plugin. I have also removed the unused python modules, and solved the mypy issue.