Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutation CreateProduct > Product created with empty input to the required field 'engagementId' #861

Closed
iPiyushPatel opened this issue Jul 30, 2020 · 3 comments · Fixed by #875
Assignees
Labels
bug Something isn't working
Milestone

Comments

@iPiyushPatel
Copy link
Contributor

Describe the bug
mutation CreateProduct > Product created with empty input to the required field 'engagementId'

Steps to Reproduce
On Graphql playground or Postman - create a API request as below snap & attached notepad file and execute request.

Expected Result
Product should not be created with empty input to the required field and Validation Error should be thrown for 'engagementId' field.

Actual Result
Product is created successfully with the empty 'engagementId' field.
See video - https://drive.google.com/file/d/1VDifDqbbQvDgf6bWj9inXxKhCgQ5v1lf/view?usp=drivesdk

GraphQL Query ( createProduct ):
image

Query and Input File
createProduct_RequiredField_blank.txt

CordAPIV3# aaecaf0

@reneepe
Copy link
Contributor

reneepe commented Jul 31, 2020

@michaelmarshall Is the engagementId a required field? We're allowed to create products without it.

image.png

@michaelmarshall
Copy link
Contributor

I'm not sure. We may have singleton products in the DB. meaning there will be only one of them and multiple engagements may point to them. @sethmcknight

@michaelmarshall michaelmarshall added the bug Something isn't working label Jul 31, 2020
@tjgersho tjgersho self-assigned this Aug 4, 2020
@tjgersho tjgersho linked a pull request Aug 5, 2020 that will close this issue
@tjgersho tjgersho removed a link to a pull request Aug 5, 2020
@tjgersho tjgersho linked a pull request Aug 5, 2020 that will close this issue
@tjgersho tjgersho closed this as completed Aug 6, 2020
@reneepe reneepe added this to the Sprint 14 milestone Aug 17, 2020
@iPiyushPatel
Copy link
Contributor Author

Hi @tjgersho @reneepe @michaelmarshall
I can still replicate the issue on the latest master 3bec105.
See video - https://drive.google.com/file/d/1Q-LNOgFBKoKN1TTSKo7-jsOgH4n6qQIg/view?usp=drivesdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants