Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutation CreateProduct > Product can be created with any input values to the 'produces' field #858

Closed
iPiyushPatel opened this issue Jul 30, 2020 · 4 comments · Fixed by #875
Assignees
Labels
bug Something isn't working
Milestone

Comments

@iPiyushPatel
Copy link
Contributor

Describe the bug
mutation CreateProduct > Product can be created with any input values to the 'produces' field.

Steps to Reproduce
On Graphql playground or Postman - create a API request as below snap & attached notepad file and execute request.

Expected Result
Specific Validation should be present for the length or inputs to the 'produces' field.

Actual Result
Product created successfully with any input values to the 'produces' field.
See video - https://drive.google.com/file/d/1ycZYNSWyhrSZbRSr03jxHZyjmmABLYZu/view?usp=drivesdk

GraphQL Query ( createProduct ):
image

Query and Input File
createProduct_producesID.txt

CordAPIV3# aaecaf0

@reneepe
Copy link
Contributor

reneepe commented Jul 30, 2020

@michaelmarshall What should be the parameters for the "produces" value? Right now, it appears to have no limit.

image.png

@michaelmarshall
Copy link
Contributor

Not sure yet. A good question to hold for when we implement this.

@michaelmarshall michaelmarshall added the bug Something isn't working label Jul 31, 2020
@tjgersho tjgersho self-assigned this Aug 4, 2020
@tjgersho
Copy link
Contributor

tjgersho commented Aug 5, 2020

@reneepe and @michaelmarshall , produces is an ID for story, film, song, and literacy-material. So this product will have this produces.
produces and scriptureReference can not exists at the same time. If produces is inputted, scriptureReference is no meaning.
Story, film, song and lit-material have their own scriptureReference.

@tjgersho tjgersho linked a pull request Aug 5, 2020 that will close this issue
@tjgersho tjgersho closed this as completed Aug 6, 2020
@reneepe reneepe added this to the Sprint 14 milestone Aug 17, 2020
@iPiyushPatel
Copy link
Contributor Author

Hi @tjgersho @reneepe @michaelmarshall
I can still replicate the issue for the empty input to produces field.
See video - https://drive.google.com/file/d/18poxhQxKDJnwHx0JZT5Z-gSx-bzQG6dh/view?usp=drivesdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants