Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to put in offering publication wizard step 2: data access #6

Closed
3 of 5 tasks
xamcost opened this issue Oct 21, 2024 · 4 comments
Closed
3 of 5 tasks
Assignees
Labels
Func: Offering Publication Issues related to offering publication help wanted Extra attention is needed Type: enhancement New feature or request

Comments

@xamcost
Copy link
Collaborator

xamcost commented Oct 21, 2024

Hi there! The goal of this issue is to decide what to put in the second step of the offering publication wizard, dealing with the access to the data asset to be published. This step aims at gathering all information needed by the connector to fetch the data from its source. I guess most of these information will not appear in the offering self-description, but will be stored in the connector, right ?

⚠️ We (marketplace developers) assumed that data sources can only be accessed through HTTP requests! Please tell us if it isn't the case.

More precisely, this page should contain:

  • URL to the data source + type of request (GET, POST, ...), required.
  • an authentication/API key
  • a body for the request (not needed for GET requests though).
  • a list of headers to add to the request, optional.
  • a list of query parameters to add to the request, optional.

Note that many of these parameters could be exposed on the consumer side as well, when requesting a transfer. For instance, the consumer could add a subpath to the request URL, as well as a body, headers and query parameters (potentially overwriting the one set by the provider). Please let us know if this should be the case. I suggest to discuss the interface for this in a separate issue.

At date of writing, this step looks like this:
image

@xamcost xamcost added Type: enhancement New feature or request help wanted Extra attention is needed Func: Offering Publication Issues related to offering publication labels Oct 21, 2024
@xamcost
Copy link
Collaborator Author

xamcost commented Oct 22, 2024

Pinging @psotres , @juanrasantana and @telsaleh for their feedback! Compared to step 1 described in #5 , there are much more questions to address here. Highlighting them:

This step aims at gathering all information needed by the connector to fetch the data from its source. I guess most of these information will not appear in the offering self-description, but will be stored in the connector, right ?

⚠️ We (marketplace developers) assumed that data sources can only be accessed through HTTP requests! Please tell us if it isn't the case.

Note that many of these parameters could be exposed on the consumer side as well, when requesting a transfer. For instance, the consumer could add a subpath to the request URL, as well as a body, headers and query parameters (potentially overwriting the one set by the provider). Please let us know if this should be the case.

And of course any other feedback you see fit.

@psotres
Copy link

psotres commented Oct 22, 2024

This is related to EDC data plane framework (more info in 1 and 2).

In the short term you can stick to your HTTP assumption, but EDC data plane can support other technologies (3, 4, 5,...) and the required config parameters is technology dependant.

@xamcost
Copy link
Collaborator Author

xamcost commented Oct 23, 2024

Thank you for your feedback @psotres . Ok we will stick to HTTP then. Yet there are two things we would need to know, but most likely @telsaleh , @juanrasantana or INRIA can answer:

  1. could we get an example of what payload to pass to the offering management component for offering creation/publication ? We tried to infer many of them based on the Sedimark ontology, but we couldn't see any fields in the defined objects such as Offering or AssetProvision corresponding to the request to perform to the HTTP data source endpoint, but maybe we are just missing it ?
  2. will the marketplace only need to communicate with the offering management components to send it the data we collected from users about their offerings (and then offering management communicates with connector), or will it also need to send some info to the connector to identify the data source related to the offering ?

Thanks in advance!

@xamcost xamcost transferred this issue from another repository Oct 24, 2024
@xamcost
Copy link
Collaborator Author

xamcost commented Jan 14, 2025

Closing since it is now covered by #8 and the fields to show in this form will be dictated by the ontology.

@xamcost xamcost closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Func: Offering Publication Issues related to offering publication help wanted Extra attention is needed Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants