Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor catalogue browsing to work with a mock response #15

Closed
xamcost opened this issue Nov 8, 2024 · 0 comments · Fixed by #14
Closed

Refactor catalogue browsing to work with a mock response #15

xamcost opened this issue Nov 8, 2024 · 0 comments · Fixed by #14
Assignees
Labels
Func: Offering Discovery Issues related to catalogue browsing Type: maintenance Refactoring, CI/CD

Comments

@xamcost
Copy link
Collaborator

xamcost commented Nov 8, 2024

Hi there! The goal of this issue is to remove the example catalogue we've been using in our app so far to replace it with a mock response closer to what is expected from the Sedimark local catalogue component. As mentioned in this post, this mock response should be a simple json array such as:

[
  {"title": "Lung cancer 2019", "short_description": "This dataset...", "provider": "Atos", "price": 2.5, "created": "2022:11:15T23:54:00", "keywords": [...]},
  {"title": "Billionaire 2023", "short_description": "This dataset...", "provider": "Surrey", "price": 3.5, "created": "2022:12:01T23:54:00", "keywords": [...]},
 ...
]

It should contain only the information needed in the cards representing the results in the catalogue browsing page. It should not be influenced by other offering data that may appear in the offering contracting page (#9 ) or in the offering management dashboard (#11 and #12 ): these will be mocked directly or separately.

As a final note, we should keep in mind that the list of providers appearing in the filters of the catalogue browsing page is not built from this mock response. We assume that a separate request will be made to fetch it, so it should be mocked separately.

@xamcost xamcost added Func: Offering Discovery Issues related to catalogue browsing Type: maintenance Refactoring, CI/CD labels Nov 8, 2024
@NaryLozano NaryLozano linked a pull request Nov 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Func: Offering Discovery Issues related to catalogue browsing Type: maintenance Refactoring, CI/CD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants