Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exe-run in setup does not work with relative path #134

Closed
janvanhumbeek opened this issue Nov 9, 2015 · 3 comments
Closed

exe-run in setup does not work with relative path #134

janvanhumbeek opened this issue Nov 9, 2015 · 3 comments

Comments

@janvanhumbeek
Copy link
Contributor

In NBi.Xml.Decoration.Command, the string FullPath is not constructed correctly if the path isn't rooted:

public string FullPath
{
    get
    {
        var fullPath = string.Empty;
        if (Path.IsPathRooted(InternalPath) || String.IsNullOrEmpty(Settings.BasePath))
            fullPath = InternalPath + Name;
        else
            fullPath = Settings.BasePath + fullPath + Name;

        return fullPath;
    }
}

should be

public string FullPath
{
    get
    {
        var fullPath = string.Empty;
        if (Path.IsPathRooted(InternalPath) || String.IsNullOrEmpty(Settings.BasePath))
            fullPath = InternalPath + Name;
        else
            fullPath = Settings.BasePath + InternalPath + Name;

        return fullPath;
    }
}
@Seddryck Seddryck added the bug label Nov 9, 2015
@janvanhumbeek
Copy link
Contributor Author

fixed with pull-request #135

@Seddryck Seddryck added this to the 1.12 milestone Nov 9, 2015
@Seddryck
Copy link
Owner

Seddryck commented Nov 9, 2015

Fixed by your pull request

@Seddryck
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants