-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmic Text (Continuation of #179) #194
Open
LPGhatguy
wants to merge
28
commits into
main
Choose a base branch
from
cosmic-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPGhatguy
force-pushed
the
cosmic-text
branch
from
November 20, 2024 22:04
45fff93
to
05f4b22
Compare
LPGhatguy
added a commit
that referenced
this pull request
Nov 20, 2024
ルシアン様、 この度はご連絡いただき、誠にありがとうございます。大変申し訳ございませんが、現在日本に滞在しており、時差の関係でGitHubの課題に取り組むことができません。この不手際に深くお詫び申し上げます。何卒ご理解賜りますよう、お願い申し上げます。 誠心誠意、迅速に対応させていただく所存でございますので、帰国次第、優先的に課題の解決に努めさせていただきます。このたびはご迷惑をおかけしてしまい、心よりお詫び申し上げます。 敬具 ケイン |
(jokingly, directed at kane) we worked on yakui while we were in Taiwan, checkmate liberal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95.
This PR picks up where #179 left off! I didn't do a great job of reviewing this code when @msparkles was working on it, but now I'm hoping to push this work over the finish line.
I created a new branch and PR because I don't have write access to the original repo from #179.
I changed most of the widget APIs to align them when the main branch to make it easier for folks to migrate, including our game. In tandem, I'm working on upgrading our game to support the changes in this PR and using it as a layout test because it's such a big overhaul!
Remaining Issues
expanded
alongside this widget