Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmic Text (Continuation of #179) #194

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Cosmic Text (Continuation of #179) #194

wants to merge 28 commits into from

Conversation

LPGhatguy
Copy link
Member

@LPGhatguy LPGhatguy commented Nov 20, 2024

Closes #95.

This PR picks up where #179 left off! I didn't do a great job of reviewing this code when @msparkles was working on it, but now I'm hoping to push this work over the finish line.

I created a new branch and PR because I don't have write access to the original repo from #179.

I changed most of the widget APIs to align them when the main branch to make it easier for folks to migrate, including our game. In tandem, I'm working on upgrading our game to support the changes in this PR and using it as a layout test because it's such a big overhaul!

Remaining Issues

  • Split premultiplied texture format into separate change
  • Split PaintLimits into separate change
  • Investigate sizing issues when using expanded alongside this widget
  • Audit text alignment inside buttons
  • Drag operations that happen outside the textbox bounds always snap to the beginning of the box instead of the nearest position within the box

@LPGhatguy
Copy link
Member Author

Button alignment is currently a little whack. These buttons have a minimum size enforced on them which causes the text to no longer be centered it seems:
image

@LPGhatguy
Copy link
Member Author

fontdue COSMIC text
info panel original info panel progress

@LPGhatguy LPGhatguy marked this pull request as ready for review November 28, 2024 06:03
@kanerogers
Copy link
Collaborator

ルシアン様、

この度はご連絡いただき、誠にありがとうございます。大変申し訳ございませんが、現在日本に滞在しており、時差の関係でGitHubの課題に取り組むことができません。この不手際に深くお詫び申し上げます。何卒ご理解賜りますよう、お願い申し上げます。

誠心誠意、迅速に対応させていただく所存でございますので、帰国次第、優先的に課題の解決に努めさせていただきます。このたびはご迷惑をおかけしてしまい、心よりお詫び申し上げます。

敬具

ケイン

@msparkles
Copy link
Contributor

(jokingly, directed at kane) we worked on yakui while we were in Taiwan, checkmate liberal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate using Cosmic Text
3 participants