Use clamp to edge on vulkan and enable portability features #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPGhatguy
reviewed
May 17, 2024
kanerogers
force-pushed
the
use_clamp_to_edge_on_vulkan
branch
from
9c517b1
to
cf91d26
Compare
|
Apologies for the silly issues here; have been travelling a lot and am quite sleep deprived. Have force-pushed a new commit that addresses each of the comments; let me know if anything is still wonky! |
LPGhatguy
approved these changes
May 17, 2024
Ralith
approved these changes
May 17, 2024
| @@ -100,7 +100,7 @@ impl VulkanTexture { | |||
| mag_filter, | |||
| } = create_info; | |||
|
|
|||
| let address_mode = vk::SamplerAddressMode::REPEAT; | |||
| let address_mode = vk::SamplerAddressMode::CLAMP_TO_EDGE; | |||
There was a problem hiding this comment.
Shouldn't this be in the previous commit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small Vulkan fixes.