Actionbar, Device Class rewrite, Notification and more #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed RootTools and a method that invoked su rights which were left over from testing microcom applet. Further modifications in an attempt to receive a response from the Strings Ril method.
Actionbar menu has been applied removing the old menu style and adding a more up to date solution that can be easily extended and modified, resources added from the Android provided Actionbar icon sets for graphical representation of the tracking of cell, signal and location. Device class was rewritten as a non-static class which resulted in a number of changes being made to other classes to take this into account, this should have really been the way I initially wrote this class but oh well it is better now :) Screenshot of the Action bar changes can be found here: http://i57.tinypic.com/i2lw60.png
Added Persistant Notification which at present just displays the Phone Type (GSM/CDMA), but this will eventually provide the immediate and visual notification of the phone status regarding encryption/ciphering status and possibly Femtocell connections. Added dialog to prompt to enable Location Services if Location Tracking is enabled but Location is not, settings fragment will be displayed to enable location services. Cleaned up a little but of the code from my previous commit, coffee helps sharpen the mind a little of this Windows developer and Android/Java moments of enlightenment can occur :) Added GPLv3 license headers to class files.
xLaMbChOpSx
added a commit
that referenced
this pull request
Apr 6, 2014
Actionbar, Device Class rewrite, Notification, Database Helper Class and more
SecUpwN
pushed a commit
that referenced
this pull request
Jan 2, 2015
Actionbar, Device Class rewrite, Notification, Database Helper Class and more
SecUpwN
pushed a commit
that referenced
this pull request
Apr 17, 2015
Actionbar, Device Class rewrite, Notification, Database Helper Class and more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages but in summary the menu system has been totally rewritten and implemented the Actionbar, the Device class was rewritten to perform better and change it from a static class, Persistent notification was added which can be tweaked down the line and the Database helper class was created to provide application wide support.
No luck still with the OemRil Strings method although not depreciated in the AOSP source I am inclined to agree with @E3V3A with his suggestion it is, no matter what I have tried I get absolutely nothing back from this method. I will be focusing from this point forward on the Raw method which does return data as shown in the application via the Ciphering Indicator code from the Samsung Service Mode application.