-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Add placeId to map click events #691
Comments
Hey. Thanks |
For any one interested, i created a pull request fro this. i cant commit it since i dont have permissions. @SebastianM , please update my permissions in order to push the feature. |
@yosigolan I am very interested in this feature, and I would love to see your work included. However, I cannot find your pull request. Can you provide a link to your repository or to the pull request? |
@SebastianM thank you for getting back to me. Yosi |
@yosigolan I am not the maintainer of this project, but I do have a strong interest in getting your work approved and included in the next release. The standard practice when contributing to a GitHub project is to fork the repository. You can then make any changes you like in your own personal copy. When you are ready to merge, you can then open a pull request from your fork back into the main repository. This is different than cloning the repository and making changes locally. Let me know if you have any more questions. |
@benjcallaghan thanks for the explanation! i will do it. Yosi |
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked. closes issue sebholstein#691.
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked. closes issue sebholstein#691. fixes for @benjcallaghan code review comments
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked. closes issue sebholstein#691.
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked. closes issue sebholstein#691. fixes for @benjcallaghan code review comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked. closes issue sebholstein#691. fixes for @doom777 code review comments
When clicking on a point of interest on a map the emiting event will include the placeId of the location clicked. closes issue sebholstein#691. fixes for @doom777 code review comments
* feat: allow disabling a "point of interest" default info window * feat: Add placeId to map click events when clicking on a point of interest on a map the emiting event will include the `placeId` of the location clicked. allow disabling a "point of interest" default info window. Use it by passing a boolean value to the new property isToShowDefaultInfoWindowForIcons when initializing the map. Default value is `true`. closes issue #691. closes issue #1539.
When clicking on a point of interest on a map the event returns the placeId of the location clicked. It would be nice to get this in the click event with the lat,lng.
The text was updated successfully, but these errors were encountered: