unsubscribing fitBoundsSubscription when necessary #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teotoplak
changed the title
teotoplak
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1810 +/- ##
=======================================
Coverage 47.97% 47.97%
=======================================
Files 47 47
Lines 1999 2001 +2
Branches 177 178 +1
=======================================
+ Hits 959 960 +1
- Misses 1036 1037 +1
Partials 4 4
Continue to review full report at Codecov.
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ghost
reopened this
ghost
approved these changes
Jul 12, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the fitBounds are not automatically computed, unsubscription from existing fitBoundsSubscription should follow.
Fixing an edge case problem where if user was using automatic fitBounds calculation suddenly switches to fitBounds object (e.g. LngLatBoundsLiteral) and then provided fitBounds by user would be overwritten by the active subscription.
This is quick fix.