-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use packagr to build as angular package format #1634
Conversation
e369cfa
to
1b73a7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1634 +/- ##
==========================================
- Coverage 40% 39.96% -0.04%
==========================================
Files 41 41
Lines 1800 1799 -1
Branches 147 154 +7
==========================================
- Hits 720 719 -1
Misses 1079 1079
Partials 1 1
Continue to review full report at Codecov.
|
hey @terencehonles . Thanks for sending the PR. Can you please merge the changes from master into your branch? Make sure it's FF only so there are no merge commits. Thanks in advance! |
979e40b
to
cd13869
Compare
@doom777 @SebastianM this PR should be updated, but as I noted in the description I only did limited testing in an Angular 7/8 app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change, and works in my case. However this PR cannot be merge without its follow up, since it takes a bunch of things back like versioning
eddd5c5
to
c249ecd
Compare
I updated the code to match master. I haven't had a chance to test it, but it does build w/o any warnings. |
c249ecd
to
2b1dec4
Compare
I updated some more of the dev dependencies and cleaned up some of the tools I made unnecessary and fixed a test that broke when upgrading versions (I had also fixed it on #1648 ). I still haven't tested it aside from ensuring it builds, but it should be up to date now. |
It does seem the changes still build against the application we have, but I don't have the right data locally to run it so I'll have to test running the actual application elsewhere later. To test you can use the release or more specifically ngmaps.core-2.tgz (The other was built when I initially drafted this PR) |
The changes do still seem to work as before. I don't use any package other than |
Let's not let this get stale again. It wasn't my fault this wasn't merged in earlier. There was some clean up I was able to add because there was more time, but this PR is basically the same as it was in May aside from resolving merge conflicts. We need to get this into mainline so changes are made with respect to this change rather than me trying to resolve what happened in the meanwhile. If there is concern about the other builds, we need to add some tests or easy way of verifying they are built correctly. The existing bundle formats that have been moved/updated should be prioritized, and new formats should be fixed as they are noticed to be broken (if they even are) Just my 2¢ |
let's give @SebastianM a few days to review it. |
This PR attempts to convert this repo to use ng-packagr to produce builds according to the Angular package format which is needed for AoT builds, and will probably be required as we progress from Angular 7 to beyond.
I tried to leave most things as they were, but the changes I made were the following:
scripts/update-package-json.js
are copied from the root into the subpackage package.json)This does seem to work for us, but there are a couple things that have not been tested or are things to point out:
installcopy the core library to node_modules after building it and then build the peer libraries. I believe this is related to the issue Feature: dependencies between npm packages ng-packagr/ng-packagr#1174 and there is not a more elegant solution to this. (If there is then that should be done)