feat(AgmMap): fix fitBounds causing protractor timeout #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix fitBounds input in map.ts directive causing timeout in protractor tests. _fitBoundsSubscription is now run outside angular ngZone to prevent protractor from waiting for sample and timer rxjs operators to sync map bounds. closes #1548
Codecov Report
@@ Coverage Diff @@
## master #1611 +/- ##
==========================================
- Coverage 33.25% 33.21% -0.05%
==========================================
Files 37 37
Lines 1636 1638 +2
Branches 128 128
==========================================
Hits 544 544
- Misses 1090 1092 +2
Partials 2 2
Continue to review full report at Codecov.
|
|
Hey, the maintainer is away. We are running a crowdsourced fork. Can you please forward your PR to github.com/agm-preview/angular-google-maps ? |
ghost
self-assigned this
ghost
approved these changes
May 30, 2019
|
Looks great, @marcin-j can you please update your branch from master, and then I'll merge this |
msenosiain
approved these changes
May 30, 2019
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fitBounds input in map.ts directive causing timeout in protractor
tests. _fitBoundsSubscription is now run outside angular ngZone to
prevent protractor from waiting for sample and timer rxjs operators
to sync map bounds.
closes #1548