Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GoogleMapsAPILoader): change default API version #1577

Merged
merged 1 commit into from
Jan 20, 2019

Conversation

sebholstein
Copy link
Owner

Fixes #1573

This changes the default Google Maps API version to quarterly.

More details about the new versioning schema here: https://developers.google.com/maps/documentation/javascript/versions

@codecov
Copy link

codecov bot commented Jan 20, 2019

Codecov Report

Merging #1577 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1577   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files          36       36           
  Lines        1531     1531           
  Branches      123      123           
=======================================
  Hits          466      466           
  Misses       1063     1063           
  Partials        2        2
Impacted Files Coverage Δ
...e/services/maps-api-loader/lazy-maps-api-loader.ts 85.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6395d...063b071. Read the comment docs.

This changes the default version of the Google Maps API to `quarterly`
because the Google Maps team changed the version strategy.

BREAKING CHANGES
This could change the Google Maps API version - so please check if you
need to change the setting of the `apiVersion` attribute in the
`AgmCodeModule.forRoot()` call.
@sebholstein sebholstein merged commit 2fc1a21 into master Jan 20, 2019
@ghost ghost deleted the feat-versioning branch September 17, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant