Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a representation of a low-rank symmetric matrix #9

Open
sethaxen opened this issue Jun 22, 2023 · 1 comment
Open

Using a representation of a low-rank symmetric matrix #9

sethaxen opened this issue Jun 22, 2023 · 1 comment

Comments

@sethaxen
Copy link

Currently the C matrix is allocated as dense and updated in-place using rank-1 updates. This is fine when the data is not large (see #8) or when the rank is close to the size of the data, but otherwise it will be inefficient in terms of both storage and computation.

A better alternative would be to have an AbstractMatrix type that stores the rank-1 updates as either one long vector or a vector of vectors and then implement the necessary methods for this to act on other vectors or matrices.

@SebastianCallh
Copy link
Owner

You are absolutely right and that's a good suggestion. I have not pursued any optimizations yet since I don't fully trust the current implementation (#5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants