Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAHeaderFieldsTest>>#testCrLf uses non-portable method #673

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments
Closed

WAHeaderFieldsTest>>#testCrLf uses non-portable method #673

GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

WAHeaderFieldsTest>>#testCrLf sends String crlf.  String class>>#crlf is not 
portable. 

There is a Slime rewrite rule for it:
--snip--
  replace: 'String crlf' with: '(String with: Character cr with: Character lf)';
--snip--

Original issue reported on code.google.com by [email protected] on 3 Aug 2011 at 8:54

@GoogleCodeExporter
Copy link
Author

Name: Seaside-Tests-Core-jok.242
Author: jok
Time: 3 August 2011, 3:28:02 pm
UUID: 56bc5088-f404-b941-9487-94abbc7872be
Ancestors: Seaside-Tests-Core-lr.241

Fix Issue 673: WAHeaderFieldsTest>>#testCrLf uses non-portable method
 - rewrite rule is replace 'String crlf' with '(String with: Character cr with: Character lf)'

Original comment by [email protected] on 3 Aug 2011 at 9:08

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

We also had a rule for this one. Looks like we got really sloppy.

Original comment by [email protected] on 6 Aug 2011 at 8:50

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant