Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all package names follow the naming conventions #163

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 19 comments
Closed

Not all package names follow the naming conventions #163

GoogleCodeExporter opened this issue Mar 25, 2015 · 19 comments
Labels
auto-migrated Priority-High Type-Defect

Comments

@GoogleCodeExporter
Copy link 

http://code.google.com/p/seaside/wiki/PackageNaming

Original issue reported on code.google.com by renggli on 17 Sep 2008 at 8:29
@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 17 Sep 2008 at 10:21

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Renamed most of them:

Name: Seaside-Tests-All-jf.1
Author: jf
Time: 17 September 2008, 1:15:34 pm
UUID: 8153e70e-c4f7-de4c-8914-d5d89eaf2896
Ancestors: 

Rename Seaside-Tests to Seaside-Tests-All based on new package naming rules at:
http://code.google.com/p/seaside/wiki/PackageNaming

See http://code.google.com/p/seaside/issues/detail?id=163

I also categorized the tests further as I think the tests should be split up 
further
to enable testing the lower layers without the higher layers loaded but I 
didn't want
to actually split them now in case they introduced ugly dependencies.


Name: Seaside-Tests-Development-jf.1
Author: jf
Time: 17 September 2008, 1:16:55 pm
UUID: 67cd424a-42cf-9b4a-b8c8-84ba38a316fe
Ancestors: 

Rename Seaside-Development-Tests to Seaside-Tests-Development



Name: Seaside-Tests-Squeak-All-jf.1
Author: jf
Time: 17 September 2008, 1:18:42 pm
UUID: 08ace56f-49eb-884c-ad8d-f8b54a948f97
Ancestors: 

Rename Seaside-Squeak-Tests to Seaside-Tests-Squeak-All



Name: Seaside-Tests-Squeak-Kom-jf.1
Author: jf
Time: 17 September 2008, 1:19:47 pm
UUID: 04ef6e62-a601-414e-8de1-4b571ee7a364
Ancestors: 

Rename Seaside-Squeak-Tests-Kom to Seaside-Tests-Squeak-Kom



Name: RSS-Tests-Core-jf.1
Author: jf
Time: 17 September 2008, 1:22:30 pm
UUID: 0a19c3d7-8815-0841-aeae-6b11b01bfcb0
Ancestors: 

Rename Seaside-Squeak-Tests-Kom to Seaside-Tests-Squeak-Kom



Name: JavaScript-Tests-Core-jf.1
Author: jf
Time: 17 September 2008, 1:35:25 pm
UUID: fe9e6760-425e-f84c-9234-bd615ee58271
Ancestors: 

Rename JavaScript-Tests to JavaScript-Tests-Core



Name: LivePipe-Tests-Core-jf.1
Author: jf
Time: 17 September 2008, 1:41:53 pm
UUID: f81fd246-ee37-e149-af73-8ebfb2705306
Ancestors: 

Rename LivePipe-Tests to LivePipe-Tests-Core



Name: Seaside-Tests-Color-jf.1
Author: jf
Time: 17 September 2008, 1:46:16 pm
UUID: cab13b45-9d81-9e49-b6d0-48ed2b9e3511
Ancestors: 

Rename Seaside-Color-Tests to Seaside-Tests-Color

Original comment by [email protected] on 17 Sep 2008 at 11:54

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Remaining problematic packages:

Seaside-Email-*
Seaside-HTML5-*
Seaside-Internet-Explorer-*
Seaside-Rest-*

All of these have Core, which is maybe not needed... I dunno. I'm punting to 
Lukas.

Original comment by [email protected] on 17 Sep 2008 at 11:58

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Why is the package called Seaside-Tests-All when it does not contain all tests?

Original comment by [email protected] on 17 Sep 2008 at 12:01

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Because it needs to be called Tests-Something and I couldn't think of anything 
else.
Tests-Core doesn't make sense because it also includes tests for lots of other
packages. I suppose it could be called Tests-Environment since it basically 
currently
depends on the whole environment being loaded. <shrug>

I split up the tests inside by category based on what I thought they were 
testing but
someone would need to test splitting them up into packages to see how the
dependencies look.

Original comment by [email protected] on 17 Sep 2008 at 1:29

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

I see the need but find -All _very_ misleading.

Original comment by [email protected] on 17 Sep 2008 at 2:23

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Yeah, -All postfixes is mostly used for empty packages with dependencies.

Original comment by renggli on 17 Sep 2008 at 2:39

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Well, I agree. But I couldn't think of anything else.

So anyone with a better name is free to rename it. Or they can test the 
dependencies
and split it (which would be better IMO).

Let's also not forget that Comment 3 still lists several packages that have not 
yet
been renamed so that needs to be done before this issue is marked closed.

Original comment by [email protected] on 17 Sep 2008 at 2:50

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

What about Seaside-Tests-Smalltalk to indicate that they should work on any 
dialect?

Original comment by [email protected] on 18 Sep 2008 at 4:46

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

What about Seaside-Tests-Common?

Original comment by [email protected] on 18 Sep 2008 at 12:26

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

IMHO is Seaside-Tests-Common the best so far.

Original comment by [email protected] on 18 Sep 2008 at 1:11

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 21 Sep 2008 at 5:41

  • Added labels: Milestone-2.9alpha
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Name: Seaside-Tests-HTML5-lr.1
Author: lr
Time: 22 September 2008, 10:35:32 pm
UUID: 299eb46e-5292-40cb-bfd7-c4dbc3d706d8
Ancestors: 

- renamed package from Seaside-HTML5-Tests

Name: Seaside-HTML5-lr.1
Author: lr
Time: 22 September 2008, 10:36:05 pm
UUID: 67c8a6ef-16e6-4efa-a53b-7c41f7157878
Ancestors: 

- renamed package from Seaside-HTML5-Core

Original comment by renggli on 22 Sep 2008 at 8:37

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Name: Seaside-Tests-Email-lr.1
Author: lr
Time: 22 September 2008, 10:43:34 pm
UUID: 75d18c5f-6ed9-4264-84c6-cde6cdc56d67
Ancestors: 

- renamed from Seaside-Email-Tests

Name: Seaside-Squeak-Email-lr.1
Author: lr
Time: 22 September 2008, 10:43:14 pm
UUID: c1d7e9e2-b529-4a56-a16c-7e3b71ea858d
Ancestors: 

- renamed from Seaside-Email-Squeak

Name: Seaside-Email-lr.1
Author: lr
Time: 22 September 2008, 10:42:41 pm
UUID: 8bdf5ab0-fbb9-4430-acf0-11f9a302a98e
Ancestors: 

- renamed from Seaside-Email-Core

Original comment by renggli on 22 Sep 2008 at 8:44

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Name: Seaside-InternetExplorer-lr.1
Author: lr
Time: 28 September 2008, 12:32:24 pm
UUID: 4a58edbf-22ba-4ea0-b594-045b091ef162
Ancestors: 

- renamed from Seaside-Internet-Explorer-Core-pmm.1

Name: Seaside-Tests-InternetExplorer-lr.1
Author: lr
Time: 28 September 2008, 12:33:48 pm
UUID: 331d36c2-5c78-4bdd-beca-9cf4c8819aff
Ancestors: 

renamed from Seaside-Internet-Explorer-Tests-pmm.1.mcz

Original comment by renggli on 28 Sep 2008 at 10:40

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Name: Seaside-Development-lr.1
Author: lr
Time: 28 September 2008, 1:01:38 pm
UUID: 4f359070-8c2b-4967-b905-fc0257dcf775
Ancestors: 

- renamed from Seaside-Development-Core-lr.64

Original comment by renggli on 28 Sep 2008 at 11:02

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Split Seaside-Tests-All and Seaside-Tests-Squeak-All into new subpackages based 
on
the packages they are testing:

    * Seaside-Tests-Platform
    * Seaside-Tests-Squeak-Platform
    * Seaside-Tests-Core
    * Seaside-Tests-Squeak-Core
    * Seaside-Tests-Canvas
    * Seaside-Tests-Session
    * Seaside-Tests-RenderLoop
    * Seaside-Tests-Squeak-Development
    * Seaside-Tests-Functional
    * Seaside-Tests-Squeak-Functional 

See new complete load order at: http://code.google.com/p/seaside/wiki/LoadOrder

Original comment by [email protected] on 6 Oct 2008 at 2:58

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Name: Seaside-Squeak-Kom-lr.1
Author: lr
Time: 18 October 2008, 12:02:46 pm
UUID: 6e094824-a55e-47d9-8747-d22a6cf405f1
Ancestors: 

- renamed from Seaside-Squeak-Kom-Kom-obi.4

Original comment by renggli on 18 Oct 2008 at 10:05

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

see above comments

Original comment by renggli on 18 Oct 2008 at 4:38

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-High Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter