fix: CheckVolumeExists() optimization and new GetVolumeWwn() #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskazinski
commented
May 25, 2022
jskazinski
commented
- Optimization to CheckVolumeExists() to show one volume, which produces an error log entry, but that is used to indicate that the volume does not exist
- Added GetVolumeWwn() to execute a storage controller command to retrieve the WWN. This results in a slight addition of execution time, but provides the ability to locate operating system devices based on WWN rather than IP Address and LUN.
Signed-off-by: Joe Skazinski <[email protected]>
seagate-chris
approved these changes
May 26, 2022
api.go
Outdated
| func (client *Client) GetVolumeWwn(volumeName string) (string, error) { | ||
|
|
||
| wwn := "" | ||
| response, _, err := client.ShowVolumes(volumeName) |
There was a problem hiding this comment.
just a nit, but i think you can use the 2nd result from ShowVolumes to simplify the error checking that follows?
There was a problem hiding this comment.
Good point, I will adjust to use the return status provided.
Signed-off-by: Joe Skazinski <[email protected]>
seagate-chris
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.