Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errorLimit unit requirement to docs #173

Open
GrigoryEvko opened this issue Dec 28, 2024 · 1 comment
Open

Add errorLimit unit requirement to docs #173

GrigoryEvko opened this issue Dec 28, 2024 · 1 comment

Comments

@GrigoryEvko
Copy link

All tools across SeaChest (from Seagate website) and openSeaChest use strange parsing method for --errorLimit.

sudo ./SeaChest_GenericTests -d /dev/sg1 --longGeneric --genericMode verify --repairAtEnd --errorLimit 65000


Error in option --errorLimit. Invalid argument given '65000'.
Use -h option to view command line help

looking at the source code I figured out that I need to add 'l' or 'p' to the end of the value, i.e. 65000l

sudo ./SeaChest_GenericTests -d /dev/sg1 --longGeneric --genericMode verify --repairAtEnd --errorLimit 65000l

Please add the according clarification to the docs. Thanks!

@vonericsen
Copy link
Contributor

Hi @GrigoryEvko,

Thank you for reporting this!

The reason for this is to specify limits as either logical sectors or physical sectors.
There was confusion many years ago about the difference and what Seagate and customers were using for the limits so this was added.

Most likely with updates to command line parsing as part of security enhancements this went from a default mode of "logical" to requiring the unit. I will double check if that can be fixed to allow for no units (l or p) to continue functioning as a logical sector count still.
If I cannot get the previous behavior back I will make sure the docs are updated to describe the required units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants