Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links on documentation pages #129

Closed
paul-hansen opened this issue Aug 16, 2024 · 1 comment · Fixed by #130
Closed

Broken links on documentation pages #129

paul-hansen opened this issue Aug 16, 2024 · 1 comment · Fixed by #130

Comments

@paul-hansen
Copy link
Contributor

The page: https://www.sea-ql.org/SeaORM/docs/basic-crud/select/
Contains these broken links:
filter
find_related
find_also_related
find_with_related

It appears back around 0.6 these were included in the entity::prelude so they worked then. For example, adding the version 0.6 to the url makes them work.
Doesn't work:
https://docs.rs/sea-orm/*/sea_orm/entity/prelude/struct.Select.html#method.find_also_related
Works:
https://docs.rs/sea-orm/0.6/sea_orm/entity/prelude/struct.Select.html#method.find_also_related
https://docs.rs/sea-orm/*/sea_orm/query/struct.Select.html#method.find_also_related

Might want to consider doing something to discover other broken links and perhaps add version numbers to docs.rs links so they don't break in the future.

@tyt2y3
Copy link
Member

tyt2y3 commented Aug 16, 2024

Thanks for reporting. Can you submit a PR to fix those with the non-prelude links?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants