Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip parsing empty Postgres check constraints #96

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Skip parsing empty Postgres check constraints #96

merged 1 commit into from
Jan 4, 2023

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Jan 3, 2023 •
edited
Loading

PR Info

okay now a new error: thread 'main' panicked at 'called Option::unwrap() on a None value', /Users/max/.cargo/registry/src/github.com-1ecc6299db9ec823/sea-schema-0.10.3/src/postgres/parser/table_constraints.rs:36:27

Bug Fixes

  • Skip parsing Postgres check constraints when check expression is empty

@billy1624 billy1624 self-assigned this Jan 3, 2023
@billy1624 billy1624 marked this pull request as ready for review January 3, 2023 12:29
@billy1624 billy1624 requested a review from tyt2y3 January 3, 2023 12:29
@tyt2y3
Copy link
Member

tyt2y3 commented Jan 4, 2023 •
edited
Loading

Can you post an excerpt of the Discord conversation?

@billy1624
Copy link
Member Author

Posted

@billy1624 billy1624 merged commit 9b28c3d into master Jan 4, 2023
@billy1624 billy1624 deleted the pg-skip-empty-check-constraint branch January 4, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billy1624 @tyt2y3