Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade syn to 2 #129

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Upgrade syn to 2 #129

merged 1 commit into from
Jun 20, 2024

Conversation

Dessix
Copy link
Contributor

@Dessix Dessix commented Mar 16, 2024

PR Info

New Features

  • Upgrades Syn from v1 to v2; No change in outputs should be present, though existing tests were somewhat sparse.

Changes

  • Utilizes direct emplacement of expressions instead of collapsing into literals where applicable, as syn v2 no longer surfaces literals directly for attributes.

tyt2y3
tyt2y3 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Sorry it somehow missed my inbox

@tyt2y3
Copy link
Member

tyt2y3 commented Jun 20, 2024

not sure why it doesn't trigger CI anymore

@tyt2y3 tyt2y3 changed the base branch from master to syn2 June 20, 2024 11:56
@tyt2y3 tyt2y3 merged commit f316298 into SeaQL:syn2 Jun 20, 2024
@tyt2y3 tyt2y3 mentioned this pull request Jun 20, 2024
Merged
@Dessix Dessix deleted the upgrade-syn-v2 branch June 20, 2024 12:24
@Dessix Dessix restored the upgrade-syn-v2 branch June 20, 2024 12:25
@Dessix Dessix deleted the upgrade-syn-v2 branch June 20, 2024 12:26
tyt2y3 added a commit that referenced this pull request Jun 23, 2024
@tyt2y3 @Dessix
Upgrade syn to 2 (#129) (#135)
1fe3424 
* Upgrade `syn` to `2` (#129)

* clippy

---------

Co-authored-by: Zoey <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

🎉 Released In 0.15.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sea-schema-derive relies on obsolete syn v1
2 participants
@Dessix @tyt2y3