Don't build driver for chrono/json/uuid/time/etc unless explicitly asked #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo.toml files can use the "?" operator in their sub-dependencies to avoid building the main dependency unless it is explicitly enabled by another feature This uses that operator to avoid building the driver crate for chrono/json/uuid/time/etc unless the driver crate is already enabled explicitly Fixes SeaQL#327
billy1624
reviewed
May 12, 2022
There was a problem hiding this comment.
Hey @marti4d, thanks for the contributions! Good use of the new cargo feature.
Btw this means user have to upgrade their Rust to at least 1.60 to compile SeaQuery? But I guess it's not an issue.
|
This is GREAT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo.toml files can use the "?" operator in their sub-dependencies to avoid
building the main dependency unless it is explicitly enabled by another feature
This uses that operator to avoid building the driver crate for
chrono/json/uuid/time/etc unless the driver crate is already enabled
explicitly
Fixes #327
PR Info
Fixes
Breaking Changes