-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issues-280 Rewrite drivers using proc-macro #292
Conversation
Thank you. This looked extremely brilliant! |
@tyt2y3 thank you for review. Done, renamed! Yes, all examples work as before. But, for example, if feature: |
c9671df
to
ebd6188
Compare
@tyt2y3 i rebase branch with master. |
Thank you for the explanation. I think it also obeys the rule of "feature addition" |
@tyt2y3 what should i do? |
Oh, nothing more has to be done. Great work indeed. I was thinking the scenario where two downstream creates each with a different feature set in their dependencies. And that would work in theory |
@billy1624 @tyt2y3 I have corrected the description |
PR Info
Fixes
Rewrite drivers for:
rusqlite
,sqlx_*
frommacro_rules
toproc-macro
. Inproc-macro
we can usecfg
instead of blank method for types, which enable by crate features and fix: #280I add
cfg
for implementation methods which enable by feature like:with-*
.Breaking Changes
Value::is_json
andValue::as_ref_json
when feature: with-json is disabledValue::is_time_*
andValue::as_ref_time_*
when feature: with-time is disabledValue::is_chrono_*
andValue::as_ref_chrono*
when feature: with-chrono is disabledValue::is_decimal
,Value::as_ref_decimal
andValue::decimal_to_f64
when feature: with-rust_decimal is disabledValue::is_big_decimal
,Value::as_ref_big_decimal
andValue::big_decimal_to_f64
when feature: with-bigdecimal is disabledValue::is_uuid
andValue::as_ref_uuid
when feature: with-uuid is disabledValue::is_array
andValue::as_ref_array
when feature: postgres-array is disabled