Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues-280 Fix driver for work with types #287

Closed

Conversation

ikrivosheev
Copy link
Member

@ikrivosheev ikrivosheev commented Mar 30, 2022

PR Info

Fixes

rror[E0277]: the trait bound `ValueRef<'_>: From<&bool>` is not satisfied
   --> src/main.rs:4:1
    |
4   | sea_query::sea_query_driver_rusqlite!();
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `From<&bool>` is not implemented for `ValueRef<'_>`
    |
    = help: the following implementations were found:
              <ValueRef<'a> as From<&'a [u8]>>
              <ValueRef<'a> as From<&'a rusqlite::types::Value>>
              <ValueRef<'a> as From<&'a str>>
              <ValueRef<'a> as From<Option<T>>>
    = note: required because of the requirements on the impl of `Into<ValueRef<'_>>` for `&bool`
    = note: required because of the requirements on the impl of `From<&bool>` for `ToSqlOutput<'_>`
note: required by `from`
    = note: this error originates in the macro `opt_string_to_sql` (in Nightly builds, run with -Z macro-backtrace for more info)

Breaking Changes

  • Remove blank functions for #[cfg(not(feature = "with-json"))]
  • Remove blank functions for #[cfg(not(feature = "with-time"))]
  • Remove blank functions for #[cfg(not(feature = "with-chrono"))]
  • Remove blank functions for #[cfg(not(feature = "with-rust_decimal"))]
  • Remove blank functions for #[cfg(not(feature = "with-bigdecimal"))]
  • Remove blank functions for #[cfg(not(feature = "with-uuid"))]
  • Remove blank functions for #[cfg(not(feature = "postgres-array"))]

@ikrivosheev ikrivosheev deleted the fix/issues-280_fix_drivers branch April 1, 2022 11:01
@billy1624
Copy link
Member

Thanks for contributions! @ikrivosheev Is this closed in flavour of #292?

@ikrivosheev
Copy link
Member Author

@billy1624 #292 this is my third try to fix issues. Please, review: #292. It is done.

@billy1624
Copy link
Member

Thanks @ikrivosheev, sorry for the delay. I was busy with other stuffs :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The trait is not implemented for
2 participants