Test Suite

[tyt2y3]

• create schema online
• CRUD testing
• relational query
• other advanced queries (GROUP BY, etc)
• sequential operations (read, insert / update, read again and update again)
• Refactor the test suite such that it can generalizes over Postgres and MySQL (if possible, partially to SQLite)

Ideally the test suite should:

• cover every SeaORM API
• multiple cases for each API (has result, no result etc)
• use more data types (UUID, Decimal, JSON, DateTime, etc)
• operations that are more complex and 'real world application'
• runs on SQLite, MySQL & Postgres

[samsamai]

Hi @tyt2y3 , I'm not clear about what the task sequential operations means.

[tyt2y3]

So the idea is to have several test cases with several transactions, for example (me just thinking randomly):

1. select the baker having the least sales
2. create and assign more cakes to him
3. create new order based on the the new baker's cakes
4. select and verify the result

that is what I mean by 'read, insert / update, read again and update again'

[samsamai]

Hi @tyt2y3 , thanks for the clarification, I've started to implement this but I have run into the same problem that I was asking about in the discussion area. How can I do a query such as this with the ORM:

SELECT
	baker.name, sum(lineitem.price * lineitem.quantity)

FROM
	baker
	INNER JOIN cakes_bakers ON cakes_bakers.baker_id = baker.id
	INNER JOIN cake ON cakes_bakers.cake_id = cake.id
	INNER JOIN lineitem ON lineitem.cake_id = cake.id
GROUP BY
	baker.name;

I don't seem to be able to do multiple joins in one query (for example baker::Entity::find().left_join(cake::Entity) .left_join(lineitem::Entity)) and I haven't been able to find a similar case in the codebase so I'm a bit stuck.

[tyt2y3]

There is another method in query/helper.rs

    fn join(mut self, join: JoinType, rel: RelationDef) -> Self {
        self.query()
            .join(join, rel.to_tbl.clone(), join_condition(rel));
        self
    }

That does not require a Related trait

[samsamai]

Thanks, got it working now.

[tyt2y3]

We'd want to refactor our test suite and test for Postgres & SQLite

1. generalize setup() function to obtain database url from env
2. extract & generalize any MySQL specific code
3. make the test suite passes on Postgres
4. (if no database url passed in from env, fallback to an in memory SQLite database)
   make the test suite passes on SQLite

[tyt2y3]

@samsamai can you explain what the file pg_tests is for?
Is it duplicate of bakery_chain_tests?

[tyt2y3]

Oh okay I got it now, Billy added it for testing the driver support.

[samsamai]

@tyt2y3 pg_tests was done by @billy1624 for when he was working on the pg_driver I think.

[tyt2y3]

Thank you so much for the great work indeed!