Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SeaORM instead of SeaORM in comment #1173

Closed
frederikhors opened this issue Oct 30, 2022 · 1 comment · Fixed by #1174
Closed

Use SeaORM instead of SeaORM in comment #1173

frederikhors opened this issue Oct 30, 2022 · 1 comment · Fixed by #1174
Assignees
@frederikhors

Comments

@frederikhors
Copy link
Contributor

Using clippy:doc_markdown which is included in clippy:pedantic it warns if this (the actual comment) is used:

//! SeaORM Entity. Generated by sea-orm-codegen 0.9.3

instead of:

//! `SeaORM` Entity. Generated by sea-orm-codegen 0.9.3

What do you think to change it?
@billy1624
Copy link
Member

Hey @frederikhors, the clippy:doc_markdown lint is allowed by default. But just in case, yeah, I agree changing it to ticked SeaORM.

Would you like to submit a PR and update it?

@billy1624 billy1624 moved this to Triage in SeaQL Dev Tracker Oct 31, 2022
@frederikhors frederikhors mentioned this issue Oct 31, 2022
Merged
4 tasks
@billy1624 billy1624 moved this from Triage to Done in SeaQL Dev Tracker Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frederikhors frederikhors

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update writer.rs
2 participants
@billy1624 @frederikhors