Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Performance Issue #30

Open
SydMontague opened this issue Jan 2, 2020 · 0 comments
Open

Potential Performance Issue #30

SydMontague opened this issue Jan 2, 2020 · 0 comments

Comments

@SydMontague
Copy link

My timing reports identify Task: EntityListener$$Lambda$4222/471528072(Single) as a task that takes up a large part of it's tick. While it's total impact on the server is relatively small this can still cause small lag spikes when the task runs.

Looking at the code it seems like this corresponds to this line.
This seems to update every FactionMob every time any entity dies, which appears to me to be quite wasteful given that most of the time the update is unnecessary.

-> shouldn't is be more effective to only do that call when a FactionMob dies or, alternatively, based on a timer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant