Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages #320

Open
myllynen opened this issue Nov 20, 2020 · 1 comment
Open

Improve error messages #320

myllynen opened this issue Nov 20, 2020 · 1 comment

Comments

@myllynen
Copy link

tlog error messages could be improved to make troubleshooting easier. For example:

  1. If tlog-rec-session.conf is missing the opening curly bracket, no error message is printed at all
  2. No line number or the offending string is printed for errors encountered
  3. Missing closing C-style comment report "unexpected end of data" and missing doublequote report "expected comment" are a bit misleading

While at it, please fix the last JSON example in tlog-rec-session(8) which is missing a comma after the writer line.

Thanks.
@justin-stephenson
Copy link
Collaborator

Thanks for the feedback, PRs are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justin-stephenson @myllynen