Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow generators without api templates #139

Merged
merged 1 commit into from
Dec 14, 2022
Merged

fix: allow generators without api templates #139

merged 1 commit into from
Dec 14, 2022

Conversation

ColinEberhardt
Copy link
Collaborator

No description provided.

@jhowlett-scottlogic
Copy link
Contributor

what is this PR related to?

@ColinEberhardt
Copy link
Collaborator Author

what is this PR related to?

Actually, I'm going to rethink this one ... the problem is if you don't have apiTemplates in package.json it fails in unhelpful ways. It should probably just log a more helpful error.

@jhowlett-scottlogic
Copy link
Contributor

I agree that a log and aborting forge would be the best way forward. I feel that now tags have been implemented on all existing generators and your new JS generator also supports tags, there should be a minimum requirement for new generators to support tags.

Copy link
Contributor

@jhowlett-scottlogic jhowlett-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me. very happy with the additional log message stating to increase logging level

@ColinEberhardt ColinEberhardt merged commit 08a14d7 into master Dec 14, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants