fix: file encoding of binary files in template (#155)

* Fix: file encoding of binary files in template * Fix: tests writeFileSync > copyFileSync * fix: code style with prettier * Add a comment for write to copy change Co-authored-by: Matthew Smith <[email protected]> --------- Co-authored-by: Gokberk Kocak <[email protected]> Co-authored-by: Matthew Smith <[email protected]>
ScottLogic · Feb 1, 2023 · ced85a2 · ced85a2
1 parent f784354
commit ced85a2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/src/generate.js b/src/generate.js
@@ -131,7 +131,11 @@ function processTemplateFactory(
       log.verbose("Copying to output location");
       // for other files, simply copy them to the output folder
       createNestedDirectories(schema, file, outputFolder);
-      fs.writeFileSync(`${outputFolder}/${file}`, source);
+      // Copy instead of read/write to support copying of binary files.
+      fs.copyFileSync(
+        `${generatorTemplatesPath}/${file}`,
+        `${outputFolder}/${file}`
+      );
     }
   };
 }

diff --git a/test/generate.test.js b/test/generate.test.js
@@ -50,10 +50,10 @@ describe("generate", () => {
       skipValidation: true,
       output: outDir,
     });
-    console.error(fs.writeFileSync.mock.calls);
-    expect(fs.writeFileSync).toHaveBeenCalledWith(
-      `${outDir}/${fileName}.${fileExtension}`,
-      fakeSchema
+    console.error(fs.copyFileSync.mock.calls);
+    expect(fs.copyFileSync).toHaveBeenCalledWith(
+      `${generatorPath}/template/${fileName}.${fileExtension}`,
+      `${outDir}/${fileName}.${fileExtension}`
     );
   });
 
@@ -75,7 +75,7 @@ describe("generate", () => {
     );
   });
 
-  it("should copy files in directories", async () => {
+  it("should copy non-handlebars files in directories", async () => {
     const fileShortName = "ExampleFile";
     const extension = "java";
     const basePath = `somewhere/else`;
@@ -89,9 +89,9 @@ describe("generate", () => {
       skipValidation: true,
       output: outDir,
     });
-    expect(fs.writeFileSync).toHaveBeenCalledWith(
-      `${outDir}/${basePath}/${fileShortName}.${extension}`,
-      fakeSchema
+    expect(fs.copyFileSync).toHaveBeenCalledWith(
+      `${generatorPath}/template/${basePath}/${fileShortName}.${extension}`,
+      `${outDir}/${basePath}/${fileShortName}.${extension}`
     );
   });
   it("should change the filename of Handlebars files in directories", async () => {