Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aave test harness #10

Merged
merged 19 commits into from
Oct 28, 2022
Merged

Aave test harness #10

merged 19 commits into from
Oct 28, 2022

Conversation

davidlaprade
Copy link
Contributor

Closes #6

@davidlaprade davidlaprade requested a review from apbendi October 7, 2022 14:29
apbendi
apbendi reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great @davidlaprade! A few small comments.

test/AaveAtokenFork.t.sol Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
foundry.toml Outdated Show resolved Hide resolved
test/AaveAtokenFork.t.sol Outdated Show resolved Hide resolved
test/AaveAtokenFork.t.sol Outdated Show resolved Hide resolved
test/AaveAtokenFork.t.sol Show resolved Hide resolved
test/FractionalGovernor.sol Show resolved Hide resolved
@davidlaprade davidlaprade force-pushed the aave-v3-test-harness branch 2 times, most recently from 6cc7d00 to 825f592 Compare October 22, 2022 18:58
apbendi
apbendi approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @davidlaprade. Great work figuring out how to get Aave deployed and configured. One comment nit, feel free to take or leave that feedback, and merge afterwards.

test/AaveAtokenFork.t.sol Outdated Show resolved Hide resolved
mds1
mds1 reviewed Oct 25, 2022
View reviewed changes
test/AaveAtokenFork.t.sol Outdated Show resolved Hide resolved
mds1
mds1 reviewed Oct 25, 2022
View reviewed changes
test/AaveAtokenFork.t.sol Outdated Show resolved Hide resolved
mds1
mds1 reviewed Oct 25, 2022
View reviewed changes
test/AaveAtokenFork.t.sol Outdated Show resolved Hide resolved
mds1
mds1 reviewed Oct 25, 2022
View reviewed changes
test/AaveAtokenFork.t.sol Outdated Show resolved Hide resolved
@davidlaprade davidlaprade requested a review from mds1 October 27, 2022 19:09
@davidlaprade davidlaprade requested a review from apbendi October 27, 2022 19:09
apbendi
apbendi approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Really nice work @davidlaprade.

@davidlaprade davidlaprade merged commit 7a9d4ac into master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

@apbendi apbendi apbendi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AToken Test Harness Setup
3 participants
@davidlaprade @apbendi @mds1