Changed _quorumReached function to not include abstentions (M-02) #86
+48
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contracts/CompoundGovernor.sol
Outdated
|
|
||
| /// @inheritdoc GovernorCountingFractionalUpgradeable | ||
| // solhint-disable-next-line func-name-mixedcase | ||
| function COUNTING_MODE() public pure virtual override(IGovernor, GovernorCountingFractionalUpgradeable) returns (string memory) { |
There was a problem hiding this comment.
Suggested change
| function COUNTING_MODE() public pure virtual override(IGovernor, GovernorCountingFractionalUpgradeable) returns (string memory) { | |
| function COUNTING_MODE() public pure override(IGovernor, GovernorCountingFractionalUpgradeable) returns (string memory) { |
contracts/CompoundGovernor.sol
Outdated
| } | ||
|
|
||
| /// @inheritdoc GovernorUpgradeable | ||
| /// @dev We override this function to resolve ambiguity between inherited contracts. |
There was a problem hiding this comment.
we should change the comment - we override in order to change the quorum strategy. we should also check against the GovernorUpgradeable docs to make sure the natspec is correct (aka that it doesn't reference for + abstain) and if it does, we should not inherit the natspec
garyghayrat
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #62