Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: onecommander: upgrading deletes all user-created themes #14393

Open
3 tasks done
Gitoffthelawn opened this issue Nov 12, 2024 · 0 comments
Open
3 tasks done

[Bug]: onecommander: upgrading deletes all user-created themes #14393

Gitoffthelawn opened this issue Nov 12, 2024 · 0 comments
Labels

Comments

@Gitoffthelawn
Copy link
Contributor

Gitoffthelawn commented Nov 12, 2024

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

onecommander

Expected/Current Behaviour

When Scoop upgrades OneCommander, all user-created themes get deleted.

Well, technically, they don't get deleted until the user performs a cleanup, but OneCommander won't find them unless the user goes in and manually moves them.

Steps to Reproduce

scoop update onecommander

Possible Solution

It may be as simple as adding the Themes folder to persist in the Scoop manifest. I would make that change to the manifest and create a PR, but I'm too new to Scoop to understand if that will make the entire contents of the Themes folder persist. That's not what we want. We want upstream theme updates to get applied, and user-themes to not get deleted.

ref: https://github.com/ScoopInstaller/Extras/blob/master/bucket/onecommander.json

Scoop and Buckets Version

Current Scoop version:
859d1db5 (HEAD -> master, tag: v0.5.2, origin/master, origin/HEAD) chore(release): Bump to version 0.5.2 (#6080)

'main' bucket:
b0786f752 (HEAD -> master, origin/master, origin/HEAD) ticker: Update to version 4.7.1

'extras' bucket:
b47adc59f (HEAD -> master, origin/master, origin/HEAD) wecom: Update to version 4.1.31.6017

Scoop Config

last_update                       scoop_repo                              scoop_branch
-----------                       ----------                              ------------
2024-11-12T02:49:24.1595201-00:00 https://github.com/ScoopInstaller/Scoop master

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.22621.4249
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.4249
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Additional Softwares

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant