Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorize Document and EmbeddedDocument #266

Merged
merged 7 commits into from
Jul 20, 2020
Merged

Conversation

lafrech
Copy link
Collaborator

@lafrech lafrech commented May 2, 2020

Factorize code duplicated in Document and EmbeddedDocument.

@coveralls
Copy link

coveralls commented May 2, 2020

Coverage Status

Coverage decreased (-0.06%) to 95.566% when pulling a07c363 on factorize_doc_embedded_doc into 6506fa4 on master.

@lafrech lafrech force-pushed the factorize_doc_embedded_doc branch from 9680322 to 434a00f Compare May 5, 2020 21:43
@lafrech lafrech added this to the 3.0 milestone May 8, 2020
@lafrech lafrech force-pushed the factorize_doc_embedded_doc branch 4 times, most recently from ed95878 to da52f80 Compare May 11, 2020 22:26
@lafrech lafrech mentioned this pull request May 11, 2020
@lafrech lafrech force-pushed the factorize_doc_embedded_doc branch from da52f80 to ff4470a Compare July 20, 2020 14:08
@lafrech lafrech force-pushed the factorize_doc_embedded_doc branch from ff4470a to ebdaae6 Compare July 20, 2020 14:35
@lafrech lafrech marked this pull request as ready for review July 20, 2020 14:49
@lafrech lafrech merged commit dc1cdbf into master Jul 20, 2020
@lafrech lafrech deleted the factorize_doc_embedded_doc branch July 20, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants